Re: [PATCH v2] tty: Partially revert the removal of the Cyclades public API

From: Maciej W. Rozycki
Date: Wed Jan 26 2022 - 04:22:43 EST


On Mon, 24 Jan 2022, Christoph Hellwig wrote:

> > Fix a user API regression introduced with commit f76edd8f7ce0 ("tty:
> > cyclades, remove this orphan"), which removed a part of the API and
> > caused compilation errors for user programs using said part, such as
> > GCC 9 in its libsanitizer component[1]:
>
> This looks sensible, but a #warning might be useful to get people to
> stop including this random header.

We have no precedent, but your suggestion seems reasonable to me, thanks.

Maciej