Re: [PATCH] platform/chrome: cros_ec_typec: Check for EC device

[Prashant Malani]

Hey Guenter,

On Wed, Jan 26, 2022 at 7:33 AM Guenter Roeck <groeck@xxxxxxxxxx> wrote:
>
> On Tue, Jan 25, 2022 at 8:05 PM Prashant Malani <pmalani@xxxxxxxxxxxx> wrote:
> >
> > Hi Tzung-Bi,
> >
> > Thanks for your review.
> >
> > On Tue, Jan 25, 2022 at 7:46 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Jan 26, 2022 at 01:22:03AM +0000, Prashant Malani wrote:
> > > > Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
> > > > Reported-by: Alyssa Ross <hi@xxxxxxxxx>
> > > > Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
> > >
> > > With a minor comment,
> > > Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
> > >
> > > > @@ -1076,6 +1076,12 @@ static int cros_typec_probe(struct platform_device *pdev)
> > > >
> > > >       typec->dev = dev;
> > > >       typec->ec = dev_get_drvdata(pdev->dev.parent);
> > > > +
> > >
> > > I would prefer to remove the blank line to make it look like an integrated block.
> >
> > I actually prefer it as it is. typec->dev is not really part of this
> > "integrated block", and I don't want to add another space there.
>
> But on the other side the check is part of the "integrated block".
> Maybe add an empty line between the two assignments if you want a
> separation.

OK. I'll add the space before it.

Thanks,