Re: Null pointer dereference in cros-ec-typec

[Prashant Malani]

Hi,

On Jan 20 23:51, Prashant Malani wrote:
> Hey Alyssa,
> 
> On Jan 19 20:32, Alyssa Ross wrote:
> > On Wed, Jan 19, 2022 at 12:44:06PM -0600, Mr. Chromebox wrote:
> > > On Wed, Jan 19, 2022 at 12:24 PM Prashant Malani <pmalani@xxxxxxxxxxxx> wrote:
> > > >
> > > > Thanks Alyssa,
> > > >
> > > > It looks like the right fix here should go in coreboot.
> > > >
> > > > I'll wait for a response from Matt regarding whether those EC commands
> > > > are supported on the eve EC firmware image Mr.Chromebox releases.
> > >
> > > looking at Chrome-EC branch firmware-eve-9584.B,
> > >
> > > EC_CMD_GET_PD_PORT_CAPS is *not* supported
> > > EC_CMD_USB_PD_PORTS is supported
> > >
> > > no difference in this regard between my updated EC firmware and the
> > > latest stock EC firmware provided by Google for EVE
> > >
> > > > I have a fix but I can't test it since :
> > > > - I am not sure how the Mr.Chromebox eve BIOS is compiled.
> > >
> > > same build system as upstream coreboot
> > >
> > > > - I don't have an eve.
> > >
> > > me neither :)
> > 
> > I'd be more than happy to test Coreboot patches on my eve and report
> > back on anything that needs to be checked, if that helps?  I've built
> > and installed it from source before.
> 
> Yes, this would be very helpful! Here is the link:
> https://review.coreboot.org/c/coreboot/+/61262

To close the loop here, the above patch has been submitted successfully.

Additionally, I've also pushed another patch to the kernel driver [1]
which checks for the null pointer (for folks using older firmware).

Thanks all,

-Prashant

[1] https://lore.kernel.org/lkml/20220126190219.3095419-1-pmalani@xxxxxxxxxxxx/