Re: [RFC V1 02/31] mm/mmap: Clarify protection_map[] indices

From: Anshuman Khandual
Date: Wed Jan 26 2022 - 23:07:15 EST




On 1/26/22 12:46 PM, Christoph Hellwig wrote:
>> + [VM_NONE] = __P000,
>> + [VM_READ] = __P001,
>> + [VM_WRITE] = __P010,
>> + [VM_READ|VM_WRITE] = __P011,
>> + [VM_EXEC] = __P100,
>> + [VM_EXEC|VM_READ] = __P101,
>> + [VM_EXEC|VM_WRITE] = __P110,
>> + [VM_EXEC|VM_READ|VM_WRITE] = __P111,
>> + [VM_SHARED] = __S000,
>> + [VM_SHARED|VM_READ] = __S001,
>> + [VM_SHARED|VM_WRITE] = __S010,
>> + [VM_SHARED|VM_READ|VM_WRITE] = __S011,
>> + [VM_SHARED|VM_EXEC] = __S100,
>> + [VM_SHARED|VM_READ|VM_EXEC] = __S101,
>> + [VM_SHARED|VM_WRITE|VM_EXEC] = __S110,
>> + [VM_SHARED|VM_READ|VM_WRITE|VM_EXEC] = __S111
>
> Please add whitespaces around the | operators.

Sure, will add.

>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>