Re: [PATCH] mm/mmzone.h: remove unused macros

From: David Hildenbrand
Date: Thu Jan 27 2022 - 04:55:33 EST


On 27.01.22 10:32, Miaohe Lin wrote:
> Remove pgdat_page_nr, nid_page_nr and NODE_MEM_MAP. They are unused now.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
> include/linux/mmzone.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index aed44e9b5d89..6c004256d943 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -920,12 +920,6 @@ typedef struct pglist_data {
>
> #define node_present_pages(nid) (NODE_DATA(nid)->node_present_pages)
> #define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages)
> -#ifdef CONFIG_FLATMEM
> -#define pgdat_page_nr(pgdat, pagenr) ((pgdat)->node_mem_map + (pagenr))
> -#else
> -#define pgdat_page_nr(pgdat, pagenr) pfn_to_page((pgdat)->node_start_pfn + (pagenr))
> -#endif
> -#define nid_page_nr(nid, pagenr) pgdat_page_nr(NODE_DATA(nid),(pagenr))
>
> #define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn)
> #define node_end_pfn(nid) pgdat_end_pfn(NODE_DATA(nid))
> @@ -1101,7 +1095,6 @@ static inline struct pglist_data *NODE_DATA(int nid)
> {
> return &contig_page_data;
> }
> -#define NODE_MEM_MAP(nid) mem_map
>
> #else /* CONFIG_NUMA */
>

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb