Re: [PATCH] ALSA: usb-audio: initialize variables that could ignore errors

From: Takashi Iwai
Date: Thu Jan 27 2022 - 08:41:33 EST


On Wed, 26 Jan 2022 19:21:42 +0100,
trix@xxxxxxxxxx wrote:
>
> From: Tom Rix <trix@xxxxxxxxxx>
>
> clang static analysis reports this representative issue
> mixer.c:1548:35: warning: Assigned value is garbage or undefined
> ucontrol->value.integer.value[0] = val;
> ^ ~~~
>
> The filter_error() macro allows errors to be ignored.
> If errors can be ignored, initialize variables
> so garbage will not be used.
>
> Fixes: 48cc42973509 ("ALSA: usb-audio: Filter error from connector kctl ops, too")
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Thanks, applied.


Takashi