Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization

[Michal Hocko]

On Thu 27-01-22 15:39:55, Mike Rapoport wrote:
> On Thu, Jan 27, 2022 at 09:53:03AM +0100, Michal Hocko wrote:
[...]
> > +	pgdat->nr_zones = 0;
> > +	pgdat->kswapd_order = 0;
> > +	pgdat->kswapd_highest_zoneidx = 0;
> > +	pgdat->node_start_pfn = 0;
> > +	for_each_online_cpu(cpu) {
> > +		struct per_cpu_nodestat *p;
> > +
> > +		p = per_cpu_ptr(pgdat->per_cpu_nodestats, cpu);
> > +		memset(p, 0, sizeof(*p));
> > +	}
> 
> It seems to me that most of this is already done by free_area_init_node()
> at boot time anyway. Do I miss something?

As already replied to David I really didn't want to change the existing
logic.
-- 
Michal Hocko
SUSE Labs