Re: [PATCH v1 1/1] docs: process: submitting-patches: Clarify the Reported-by usage

From: Jonathan Corbet
Date: Thu Jan 27 2022 - 11:07:37 EST


Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:

> It's unclear from "Submitting Patches" documentation that Reported-by
> is not supposed to be used against new features. (It's more clear
> in the section 5.4 "Patch formatting and changelogs" of the "A guide
> to the Kernel Development Process", where it suggests that change
> should fix something existing in the kernel. Clarify the Reported-by
> usage in the "Submitting Patches".
>
> Reported-by: Florian Eckert <fe@xxxxxxxxxx>

You're sure this added documentation isn't a new feature that shouldn't
have a Reported-by? :)

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Documentation/process/submitting-patches.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 31ea120ce531..24c1a5565385 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -495,7 +495,8 @@ Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
> The Reported-by tag gives credit to people who find bugs and report them and it
> hopefully inspires them to help us again in the future. Please note that if
> the bug was reported in private, then ask for permission first before using the
> -Reported-by tag.
> +Reported-by tag. A new feature can't be reported since there is no code in the
> +kernel to fix.

How about instead something like "Reported-by is intended for bugs;
please do not use it to credit feature requests"?

(i.e. I want the shed in green :)

Thanks,

jon