Re: [PATCH v2 1/2] i2c: tegra: allow DVC support to be compiled out

[Wolfram Sang]

Hi Michał,

> ---
> v2: remove KConfig symbol as per Dmitry Osipenko's suggestion.
>     (Assuming that for Tegra20 the DVC part will be used anyway.)
> 
> Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>

Your SoB should be above the "---" line.

> +#define IS_DVC(dev) (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) && dev->is_dvc)

'checkpatch --strict' IMO rightfully mentions that 'dev' should be in
paranthesis when being used.

Both comments apply to patch 2 as well. Otherwise looks good!

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature