Re: [PATCH net] net: dev: Detect dev_hold() after netdev_wait_allrefs()

From: Eric Dumazet
Date: Thu Jan 27 2022 - 21:23:25 EST


On Thu, Jan 27, 2022 at 6:22 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 28 Jan 2022 03:14:14 +0100 Jann Horn wrote:
> > Oh. Whoops. That's what I get for only testing without CONFIG_PCPU_DEV_REFCNT...
> >
> > I guess a better place to put the new check would be directly after
> > checking for "dev->reg_state == NETREG_UNREGISTERING"? Like this?
>
> Possibly a very silly suggestion but perhaps we should set
> the pointer to NULL for the pcpu case and let it crash?

It is already set to 0