Re: [PATCH] net: usb: r8152: Add MAC passthrough support for RTL8153BL

[Aaron Ma]

On 1/27/22 22:19, Andrew Lunn wrote:
> On Thu, Jan 27, 2022 at 06:01:09PM +0800, Aaron Ma wrote:
> > RTL8153-BL is used in Lenovo Thunderbolt4 dock.
> > Add the support of MAC passthrough.
> > This is ported from Realtek Outbox driver r8152.53.56-2.15.0.
> >
> > There are 2 kinds of rules for MAC passthrough of Lenovo products,
> > 1st USB vendor ID belongs to Lenovo, 2nd the chip of RTL8153-BL
> > is dedicated for Lenovo. Check the ocp data first then set ACPI object
> > names.
> >
> > Suggested-by: Hayes Wang <hayeswang@xxxxxxxxxxx>
> > Signed-off-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
> > ---
> >   drivers/net/usb/r8152.c | 44 ++++++++++++++++++++++-------------------
> >   1 file changed, 24 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> > index ee41088c5251..df997b330ee4 100644
> > --- a/drivers/net/usb/r8152.c
> > +++ b/drivers/net/usb/r8152.c
> > @@ -718,6 +718,7 @@ enum spd_duplex {
> >   #define AD_MASK			0xfee0
> >   #define BND_MASK		0x0004
> >   #define BD_MASK			0x0001
> > +#define BL_MASK                 BIT(3)
>
> Just to be sure, this is defined by Realtek? This is not just Lenovo
> just misusing a reserved bit?

From what I know, It's defined by Realtek to identify customized product.
It shouldn't be misusing.
Also it's used by Realtek outbox driver.

Aaron

>       Andrew