Re: [RFC PATCH 1/2] NUMA balancing: fix NUMA topology type for memory tiering system

From: Srikar Dronamraju
Date: Fri Jan 28 2022 - 00:24:13 EST


* Huang Ying <ying.huang@xxxxxxxxx> [2022-01-28 10:38:41]:

>
> One possible fix is to ignore CPU-less nodes when detecting NUMA
> topology type in init_numa_topology_type(). That works well for the
> example system. Is it good in general for any system with CPU-less
> nodes?
>

A CPUless node at the time online doesn't necessarily mean a CPUless node
for the entire boot. For example: On PowerVM Lpars, aka powerpc systems,
some of the nodes may start as CPUless nodes and then CPUS may get
populated/hotplugged on them.

Hence I am not sure if adding a check for CPUless nodes at node online may
work for such systems.

> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
> Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Cc: Rik van Riel <riel@xxxxxxxxxxx>
> Cc: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> ---
> kernel/sched/topology.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>

--
Thanks and Regards
Srikar Dronamraju