Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

From: Dan Carpenter
Date: Fri Jan 28 2022 - 02:04:23 EST


On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
>
> Am 27.01.22 um 02:44 schrieb cgel.zte@xxxxxxxxx:
> > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@xxxxxxxxxx>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?

drain_workqueue() calls flush_workqueue() repeatedly.

regards,
dan carpenter