Re: drivers/net/wireless/ath/ath11k/qmi.c:1891 ath11k_qmi_assign_target_mem_chunk() error: uninitialized symbol 'ret'.

[Kalle Valo]

(adding ath11k list)

Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
> commit: 6ac04bdc5edb418787ab2040b1f922c23464c750 ath11k: Use reserved host DDR addresses from DT for PCI devices
> config: microblaze-randconfig-m031-20220127 (https://download.01.org/0day-ci/archive/20220127/202201272025.7AWXB5T7-lkp@xxxxxxxxx/config)
> compiler: microblaze-linux-gcc (GCC) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> New smatch warnings:
> drivers/net/wireless/ath/ath11k/qmi.c:1891 ath11k_qmi_assign_target_mem_chunk() error: uninitialized symbol 'ret'.
>
> Old smatch warnings:
> drivers/net/wireless/ath/ath11k/qmi.c:2161 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
>
> vim +/ret +1891 drivers/net/wireless/ath/ath11k/qmi.c
>
> 6eb6ea51382873 Govind Singh          2020-08-14  1876  static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
> d5c65159f28953 Kalle Valo            2019-11-23  1877  {
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1878  	struct device *dev = ab->dev;
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1879  	struct device_node *hremote_node = NULL;
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1880  	struct resource res;
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1881  	u32 host_ddr_sz;
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1882  	int i, idx, ret;
> d5c65159f28953 Kalle Valo            2019-11-23  1883  
> d5c65159f28953 Kalle Valo            2019-11-23  1884  	for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
> d5c65159f28953 Kalle Valo            2019-11-23  1885  		switch (ab->qmi.target_mem[i].type) {
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1886  		case HOST_DDR_REGION_TYPE:
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1887  			hremote_node = of_parse_phandle(dev->of_node, "memory-region", 0);
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1888  			if (!hremote_node) {
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1889  				ath11k_dbg(ab, ATH11K_DBG_QMI,
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14  1890  					   "qmi fail to get hremote_node\n");
> 6ac04bdc5edb41 Anilkumar Kolli       2021-12-14 @1891  				return ret;
>
> "ret" not set.

Anil, can you send a patch to fix this?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches