Re: [RFC] nvme: Do not reject dynamic controller cntlid

From: Daniel Wagner
Date: Fri Jan 28 2022 - 05:31:47 EST


On Thu, Jan 27, 2022 at 09:17:58AM -0800, Keith Busch wrote:
> > +static inline bool nvme_ctrl_dynamic(struct nvme_ctrl *ctrl)
> > +{
> > + return ctrl->cntlid == 0xffff;
> > +}
>
> It's probably safe to assume 0xffff is dynamic, but spec suggests we
> check ID_CTRL.FCATT bit 0.

Okay, but this one is only defined for fabrics. I haven't found anything
so far which is equivalent to FCATT bit 0 for memory based transport.