Re: [PATCH 04/16] tools/include: Update atomic.h header

From: Karolina Drobnik
Date: Fri Jan 28 2022 - 06:09:30 EST


On Thu, 2022-01-27 at 13:56 +0000, Matthew Wilcox wrote:
> On Thu, Jan 27, 2022 at 02:21:22PM +0100, Karolina Drobnik wrote:
> > Add atomic_long_t typedef and atomic_long_set function so they
> >  can be used in testing.
> >
> > Signed-off-by: Karolina Drobnik <karolinadrobnik@xxxxxxxxx>
> > ---
> >  tools/include/linux/atomic.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/include/linux/atomic.h
> > b/tools/include/linux/atomic.h
> > index 00a6c4ca562b..5d2431889606 100644
> > --- a/tools/include/linux/atomic.h
> > +++ b/tools/include/linux/atomic.h
> > @@ -4,6 +4,10 @@
> >  
> >  #include <asm/atomic.h>
> >  
> > +typedef atomic_t atomic_long_t;
>
> Given this:
>
> typedef struct {
>         int counter;
> } atomic_t;
>
> your definition seems wrong.  Why not add atomic_long_t to types.h,
> adjacent to atomic_t?

Hmm, that sounds like a better idea. Will do that, thank you.