Re: [RESEND][PATCH] Documentation: added order requirement for ima_hash=

From: Mimi Zohar
Date: Fri Jan 28 2022 - 09:34:12 EST


On Fri, 2022-01-28 at 10:24 +0000, Roberto Sassu wrote:
> > From: Mimi Zohar [mailto:zohar@xxxxxxxxxxxxx]
> > Sent: Wednesday, January 26, 2022 1:48 PM
> > On Wed, 2022-01-26 at 15:41 +0800, Guozihua (Scott) wrote:
> > >
> > >
> > > The main issue lies in ima_template_desc_current called by hash_setup,
> > > which does not just read ima_template global variable, but also tries to
> > > set it if that hasn't been done already. Causing ima_template_setup to quit.
> >
> > Right, which calls ima_init_template_list(). So part of the solution
> > could be to conditionally call ima_init_template_list()
> > in ima_template_setup().
> >
> > - if (ima_template)
> > - return 1;
> > -
> > - ima_init_template_list();
> > + if (!ima_template
> > + ima_init_template_list();
>
>
> is it still necessary to call ima_init_template_list() in
> template_setup()? I saw it is called in init_ima().

All of these options are at __setup().

thanks,

Mimi