Re: [PATCH 2/2] i2c: designware: Add AMD PSP I2C bus support

From: Jan Dąbroś
Date: Fri Jan 28 2022 - 09:40:02 EST


czw., 20 sty 2022 o 18:12 Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a):
>
> On Thu, Jan 20, 2022 at 11:33:05PM +0800, kernel test robot wrote:
>
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/i2c/busses/i2c-designware-amdpsp.c: In function 'psp_send_cmd':
> > >> drivers/i2c/busses/i2c-designware-amdpsp.c:130:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
> > 130 | writeq((uintptr_t)__psp_pa((void *)req), &mbox->i2c_req_addr);
> > | ^~~~~~
> > | writel
> > cc1: some warnings being treated as errors
>
> Adding io-64-nonatomic-lo-hi.h after io.h should fix this.

Correct, thanks! Actually io.h is directly included from
io-64-nonatomic-lo-hi.h.

Best Regards,
Jan


>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>