Re: [PATCH] Revert "pinctrl: zynqmp: Unify pin naming"

From: Andy Shevchenko
Date: Fri Jan 28 2022 - 09:50:47 EST


On Fri, Jan 28, 2022 at 04:45:14PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 27, 2022 at 08:46:02PM +0100, Gerhard Engleder wrote:
> > From: Gerhard Engleder <gerhard@xxxxxxxxxxxxxxxxxxxxx>
>
> Thanks for your report, my comments below.
>
> > This reverts commit 54784ff24971ed5bd3f1056edce998148709d0a7.
> >
> > This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts
> > in arch/arm64/boot/dts/xilinx still use the old name. As a result my
> > ZCU104 has no output on serial terminal and is not reachable over
> > network.
>
> And question here again, is the pin names ABI or not?
> If it's an ABI, then it should be clarified in the documentation.
> Otherwise, I'm wondering how this even may break anything.

Meanwhile I apply this to my tree and send as fix PR to Linus.

--
With Best Regards,
Andy Shevchenko