Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Fri, 28 Jan 2022 22:15:50 +0800 you wrote:
> There are two issues with runtime pm handling in stmmac_dvr_remove():
> 
> 1. the mac is runtime suspended before stopping dma and rx/tx. We
> need to ensure the device is properly resumed back.
> 
> 2. the stmmaceth clk enable/disable isn't balanced in both exit and
> error handling code path. Take the exit code path for example, when we
> unbind the driver or rmmod the driver module, the mac is runtime
> suspended as said above, so the stmmaceth clk is disabled, but
> 	stmmac_dvr_remove()
> 	  stmmac_remove_config_dt()
> 	    clk_disable_unprepare()
> CCF will complain this time. The error handling code path suffers
> from the similar situtaion.
> 
> [...]

Here is the summary with links:
  - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()
    https://git.kernel.org/netdev/net/c/6449520391df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html