Re: [PATCH 4/7] mfd: hi6421-spmi-pmic: Use generic_handle_irq_safe().

From: Lee Jones
Date: Fri Jan 28 2022 - 11:50:10 EST


On Fri, 28 Jan 2022, Sergei Shtylyov wrote:

> On 1/28/22 4:33 PM, Lee Jones wrote:
>
> >>> generic_handle_irq() is invoked from a regular interrupt service
> >>> routing. This handler will become a forced-threaded handler on
> >>
> >> s/routing/routine/?
> >>
> >>> PREEMPT_RT and will be invoked with enabled interrupts. The
> >>> generic_handle_irq() must be invoked with disabled interrupts in order
> >>> to avoid deadlocks.
> >>>
> >>> Instead of manually disabling interrupts before invoking use
> >>> generic_handle_irq() which can be invoked with enabled and disabled
> >>> interrupts.
> >>>
> >>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> >> [...]
> >>
> >> MBR, Sergey
> >
> > What does that mean?
>
> Ah, you were asking about MBR! My best regards then. :-)

Yes this. It's okay, Dan was kind enough to enlighten me.

Every day is a school day on the list! :)

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog