Re: [ocfs2] c42ff46f97: sysctl_table_check_failed

[Linus Torvalds]

On Fri, Jan 28, 2022 at 6:49 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> Yes.  There is a register_sysctl_paths that can be used if you want/need
> the embedded directories.  That probably would have been a better
> choice for an automated conversion.
>
> But since this there is only the single file in a single directory
> register_sysctl() with the full path is perfectly fine in this case.
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

I was doing filesystem pull requests anyway, and as a result (I tend
to group things by topic if there's multiple things pending) I already
committed that patch of mine based on Jan's reviewed/tested-by, so
this reviewed-by ended up not in the tree.

But maybe somebody should check the other automated conversions for
the same issue? Hint hint.

Also, I'm somewhat unhappy about the fact that apparently the kernel
test robot already found this issue back in November of last year, yet
it made it to mainline several months later without being fixed.

It's hard to tell from this link:

  https://lists.01.org/hyperkitty/list/lkp@xxxxxxxxxxxx/thread/KQ2F6TPJWMDVEXJM4WTUC4DU3EH3YJVT/

but it does look like that original report only made it to that lkp
list and not the actual people listed on the commit itself? That would
explain why the report was overlooked.

Kind of sad.

              Linus