Re: [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib

From: Karolina Drobnik
Date: Fri Jan 28 2022 - 12:31:05 EST


On Fri, 2022-01-28 at 12:02 +0100, Karolina Drobnik wrote:
> On Thu, 2022-01-27 at 13:36 +0000, Matthew Wilcox wrote:
> > I don't think it makes much sense to move kmalloc() and not to move
> > the kmem_cache* functions.  They're all provided by slab in the
> > kernel
> > proper, so while you don't use them, I think keeping all the memory
> > allocation functions together is preferable.
>
> I wasn't sure if these functions would be used by other test suites,
> so
> I left them here. But I can move them if you think it's better to
> keep
> them together.
>

OK, now I can see why this wouldn't work - kmem_cache_alloc and
kmem_cache_free operate on radix_tree_node struct, making it specific
to this test suite.

So, for this patch, I'm going to tidy up the gfp.h header but leave
radix-tree/linux.c and lib/slab.c as they are now.