Re: [PATCH v2 0/2] tracing: Misc bugfixes

From: Tom Zanussi
Date: Fri Jan 28 2022 - 16:50:51 EST


On Fri, 2022-01-28 at 16:42 -0500, Steven Rostedt wrote:
> On Fri, 28 Jan 2022 14:08:25 -0600
> Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
>
> > There were 2 patches in v1 that were flagged by the 0day robot for
> > strncpy off-by-1 warnings:
> >
> > tracing: Remove size restriction on hist trigger cmd error
> > logging
> > tracing: Remove size restriction on synthetic event cmd error
> > logging
> >
> > warning: 'strncpy' output truncated before terminating nul
> > copying
> > as many bytes from a string as its length [-Wstringop-truncation]
> >
> > This v2 patchset consists of just those two patches with the fix
> > for
> > those warnings.
>
>
> So this just replaces the last two patches you sent previously?
>

Yes.

> Probably would have been better to send all three (since the other 4
> already made it into mainline).
>

OK, yeah, thought about doing that but guessed wrong, as usual ;-)

> But if "tracing: Remove size restriction on tracing_log_err cmd
> strings" is
> OK:
>
>

Yeah, that one is ok as-is without changes.

Tom

>
https://lkml.kernel.org/r/ca965f23256b350ebd94b3dc1a319f28e8267f5f.1643319703.git.zanussi@xxxxxxxxxx
>
> then I'll just replace the other two.
>
> -- Steve