Re: [PATCH V8 05/44] x86/fpu: Refactor arch_set_user_pkey_access()

From: Dave Hansen
Date: Fri Jan 28 2022 - 17:50:47 EST


On 1/27/22 09:54, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Both PKU and PKS update their register values in the same way. They can
> therefore share the update code.
>
> Define a helper, pkey_update_pkval(), which will be used to support both
> Protection Key User (PKU) and the new Protection Key for Supervisor
> (PKS) in subsequent patches.
>
> pkey_update_pkval() contributed by Thomas
>
> Co-developed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks better than my original code. Waaaaaay simpler.

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>