Re: [PATCH v3 0/3] block, bfq: minor cleanup and fix

From: yukuai (C)
Date: Fri Jan 28 2022 - 21:05:43 EST


在 2022/01/29 9:51, Jens Axboe 写道:
On 1/28/22 6:59 PM, Yu Kuai wrote:
Changes in v3:
- fix a clerical error in patch 2

Chagnes in v2:
- add comment in patch 2
- remove patch 4, since the problem do not exist.

Yu Kuai (3):
block, bfq: cleanup bfq_bfqq_to_bfqg()
block, bfq: avoid moving bfqq to it's parent bfqg
block, bfq: don't move oom_bfqq

block/bfq-cgroup.c | 16 +++++++++++++++-
block/bfq-iosched.c | 4 ++--
block/bfq-iosched.h | 1 -
block/bfq-wf2q.c | 15 ---------------
4 files changed, 17 insertions(+), 19 deletions(-)

I'm not even looking at this until you tell me that:

a) you've actually compiled this one. which, btw, I can't believe
needs mentioning, particularly when you had enough time to keep
pinging about this patchset.

b) it's actually be run. last one was clearly not.

Hi,

I compiled and tested the patchset locally in a different version,
v4.19 specifically. However, after I decide to send them to mainline,
I made such clerical mistake and forgot to check the patches.

My sincerely apologize again...
Kuai