Re: [PATCH v2 2/2] staging: pi433: add debugfs interface

From: Paulo Miguel Almeida
Date: Fri Jan 28 2022 - 22:35:26 EST


On Wed, Jan 26, 2022 at 01:03:03PM +0100, Greg KH wrote:
>
> Breaks the build:
>
> drivers/staging/pi433/pi433_if.c:1166:25: error: initialization of ‘int (*)(struct inode *, struct file *)’ from incompatible pointer type ‘ssize_t (*)(struct inode *, struct file *)’ {aka ‘long int (*)(struct inode *, struct file *)’} [-Werror=incompatible-pointer-types]
> 1166 | .open = pi433_debugfs_regs_open,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
>

My apologies, I will be more careful next time. I must have missed
something out on my module-specific makefile.

I will incorporate the changes that Dan Carpenter suggested and submit a
new version of this patch shortly.

thanks,

Paulo A.