Re: [RFC] ARM: sa1100/assabet: move dmabounce hack to ohci driver

[Arnd Bergmann]

On Tue, Feb 1, 2022 at 4:31 PM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> > index 3c7c64ff3c0a..5f2fa46c7958 100644
> > --- a/drivers/usb/core/hcd.c
> > +++ b/drivers/usb/core/hcd.c
> > @@ -1260,7 +1260,8 @@ void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb)
> >  EXPORT_SYMBOL_GPL(usb_hcd_unlink_urb_from_ep);
> >
> >  /*
> > - * Some usb host controllers can only perform dma using a small SRAM area.
> > + * Some usb host controllers can only perform dma using a small SRAM area,
> > + * or that have restrictions in addressable DRAM.
>
> s/that //
> s/in/on/

Fixed now.

> Otherwise the USB parts of this look okay to me.  I don't have suitable
> hardware to test either.  (I wonder if anyone is still using this
> platform...)

I assumed Russell was still using the Assabet, but his last upstream
commits for sa1100 are from 2016 (merged in 2019), so that may have
changed in the meantime.

> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Thanks!

       Arnd