Re: [PATCH bpf-next 0/5] Allow CONFIG_DEBUG_INFO_DWARF5=y + CONFIG_DEBUG_INFO_BTF=y

[Daniel Borkmann]

On 2/2/22 8:05 AM, Andrii Nakryiko wrote:
> On Tue, Feb 1, 2022 at 12:56 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > This series allows CONFIG_DEBUG_INFO_DWARF5 to be selected with
> > CONFIG_DEBUG_INFO_BTF=y by checking the pahole version.
> >
> > The first four patches add CONFIG_PAHOLE_VERSION and
> > scripts/pahole-version.sh to clean up all the places that pahole's
> > version is transformed into a 3-digit form.
> >
> > The fourth patch adds a PAHOLE_VERSION dependency to DEBUG_INFO_DWARF5
> > so that there are no build errors when it is selected with
> > DEBUG_INFO_BTF.
> >
> > I build tested Fedora's aarch64 and x86_64 config with ToT clang 14.0.0
> > and GCC 11 with CONFIG_DEBUG_INFO_DWARF5 enabled with both pahole 1.21
> > and 1.23.
> >
> > Nathan Chancellor (5):
> >    MAINTAINERS: Add scripts/pahole-flags.sh to BPF section
> >    kbuild: Add CONFIG_PAHOLE_VERSION
> >    scripts/pahole-flags.sh: Use pahole-version.sh
> >    lib/Kconfig.debug: Use CONFIG_PAHOLE_VERSION
> >    lib/Kconfig.debug: Allow BTF + DWARF5 with pahole 1.21+
>
> LGTM. I'd probably combine patches 2 and 3, but it's minor. I really
> like the CONFIG_PAHOLE_VERSION and how much cleaner it makes Kconfig
> options.

+1, thanks for working on getting this enabled! I think patches 2 and 3 are
rather logically separate, so as-is is fine as well imho. Applied, thanks!