Re: [PATCH v9 15/43] x86/sev: Register GHCB memory when SEV-SNP is active

[Borislav Petkov]

On Fri, Jan 28, 2022 at 11:17:36AM -0600, Brijesh Singh wrote:
> diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
> index 24df739c9c05..b86b48b66a44 100644
> --- a/arch/x86/kernel/sev.c
> +++ b/arch/x86/kernel/sev.c
> @@ -41,7 +41,7 @@ static struct ghcb boot_ghcb_page __bss_decrypted __aligned(PAGE_SIZE);
>   * Needs to be in the .data section because we need it NULL before bss is
>   * cleared
>   */
> -static struct ghcb __initdata *boot_ghcb;
> +static struct ghcb *boot_ghcb __section(".data");
>  
>  /* Bitmap of SEV features supported by the hypervisor */
>  static u64 sev_hv_features __ro_after_init;
> @@ -161,55 +161,6 @@ void noinstr __sev_es_ist_exit(void)
>  	this_cpu_write(cpu_tss_rw.x86_tss.ist[IST_INDEX_VC], *(unsigned long *)ist);
>  }
>  
> -/*
> - * Nothing shall interrupt this code path while holding the per-CPU
> - * GHCB. The backup GHCB is only for NMIs interrupting this path.
> - *
> - * Callers must disable local interrupts around it.
> - */
> -static noinstr struct ghcb *__sev_get_ghcb(struct ghcb_state *state)

That move doesn't look like it's needed anymore, does it?

I mean, it builds even without it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette