Re: [PATCH v2] soc: renesas: Add support for reading product revision for RZ/G2L family

[Geert Uytterhoeven]

Hi Biju,

On Wed, Feb 2, 2022 at 10:51 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH v2] soc: renesas: Add support for reading product
> > revision for RZ/G2L family
> > On Fri, Jan 21, 2022 at 2:41 AM Lad Prabhakar <prabhakar.mahadev-
> > lad.rj@xxxxxxxxxxxxxx> wrote:
> > > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > As per RZ/G2L HW manual (Rev.1.00 Sep, 2021) DEV_ID [31:28] indicates
> > > product revision. Use this information to populate the revision info
> > > for RZ/G2L family.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

> > > --- a/drivers/soc/renesas/renesas-soc.c
> > > +++ b/drivers/soc/renesas/renesas-soc.c
> > > @@ -405,41 +417,38 @@ static int __init renesas_soc_init(void)
> > >
> > >                         eshi = ((product >> 4) & 0x0f) + 1;
> > >                         eslo = product & 0xf;
> > > +                       soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> > "ES%u.%u",
> > > +                                                          eshi, eslo);
> > > +               }  else if (id == &id_rzg2l) {
> > > +                       eshi =  ((product >> 28) & 0x0f);
> > > +                       soc_dev_attr->revision = kasprintf(GFP_KERNEL,
> > "Rev %u",
> > > +                                                          eshi);
> >
> > Would you mind if I would drop the "Rev " while applying?
>
> Kernel reports the below message after dropping Rev. Is it OK?
>
> [    0.018297] Detected Renesas RZ/G2L r9a07g044 1

That's indeed not so nice...

Either we have to add it back, or do something like:

-       pr_info("Detected Renesas %s %s %s\n", soc_dev_attr->family,
-               soc_dev_attr->soc_id, soc_dev_attr->revision ?: "");
+       pr_info("Detected Renesas %s %s%s%s\n", soc_dev_attr->family,
+               soc_dev_attr->soc_id, soc_dev_attr->revision ? " Rev " : "",
+               soc_dev_attr->revision ?: "");

Any other options?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds