Re: [PATCH] RISC-V: KVM: make CY, TM, and IR counters accessible in VU mode

[Jessica Clarke]

On 2 Feb 2022, at 11:14, Anup Patel <anup@xxxxxxxxxxxxxx> wrote:
> 
> On Mon, Jan 31, 2022 at 4:33 PM Mayuresh Chitale
> <mchitale@xxxxxxxxxxxxxxxx> wrote:
>> 
>> Those applications that run in VU mode and access the time CSR cause
>> a virtual instruction trap as Guest kernel currently does not
>> initialize the scounteren CSR.
>> 
>> To fix this, we should make CY, TM, and IR counters accessibile
>> by default in VU mode (similar to OpenSBI).
>> 
>> Fixes: a33c72faf2d73 ("RISC-V: KVM: Implement VCPU create, init and
>> destroy functions")
>> Cc:stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Mayuresh Chitale <mchitale@xxxxxxxxxxxxxxxx>
> 
> Thanks, I have queued this for fixes.

The formatting is clearly wrong...

> Regards,
> Anup
> 
>> ---
>> arch/riscv/kvm/vcpu.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>> 
>> diff --git a/arch/riscv/kvm/vcpu.c b/arch/riscv/kvm/vcpu.c
>> index 0c5239e05721..caaf824347b9 100644
>> --- a/arch/riscv/kvm/vcpu.c
>> +++ b/arch/riscv/kvm/vcpu.c
>> @@ -90,6 +90,7 @@ int kvm_arch_vcpu_precreate(struct kvm *kvm, unsigned int id)
>> int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)
>> {
>>        struct kvm_cpu_context *cntx;
>> +       struct kvm_vcpu_csr *reset_csr = &vcpu->arch.guest_reset_csr;
>> 
>>        /* Mark this VCPU never ran */
>>        vcpu->arch.ran_atleast_once = false;
>> @@ -106,6 +107,9 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)
>>        cntx->hstatus |= HSTATUS_SPVP;
>>        cntx->hstatus |= HSTATUS_SPV;
>> 
>> +       /* By default, make CY, TM, and IR counters accessible in VU mode */
>> +       reset_csr->scounteren=0x7;

... here

Jess

>> +
>>        /* Setup VCPU timer */
>>        kvm_riscv_vcpu_timer_init(vcpu);
>> 
>> --
>> 2.25.1
>> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv