RE: [PATCH v10 0/3] Add support for sc7280 WPSS PIL loading

[Manikanta Pubbisetty (QUIC)]

> -----Original Message-----
> From: Manikanta Pubbisetty (QUIC) <quic_mpubbise@xxxxxxxxxxx>
> Sent: Tuesday, February 1, 2022 4:22 PM
> To: agross@xxxxxxxxxx; bjorn.andersson@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> ohad@xxxxxxxxxx; mathieu.poirier@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx
> Cc: linux-remoteproc@xxxxxxxxxxxxxxx; swboyd@xxxxxxxxxxxx; linux-arm-
> msm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sibi Sankar (QUIC) <quic_sibis@xxxxxxxxxxx>;
> kuabhs@xxxxxxxxxxxx; Rakesh Pillai (QUIC) <quic_pillair@xxxxxxxxxxx>;
> Manikanta Pubbisetty (QUIC) <quic_mpubbise@xxxxxxxxxxx>
> Subject: [PATCH v10 0/3] Add support for sc7280 WPSS PIL loading
> 
> Add support for PIL loading of WPSS co-processor for SC7280 SOCs.
> 
> Changes from v9:
> - Minor cosmetic changes
> 
> Changes from v8:
> - Disallow num_proxy_pds to be more than the max allowed
> - Add "additionalProperties: false" for glink-edge property in wpss dt-bindings.
> 
> Changes from v7:
> - Use "interrupts" instead of "interrupts-extended" in DT bindings.
> - Add glink-edge properties in DT bindings.
> - Use size_t for "proxy_pd_count" in wpss remoteproc driver
> 
> Changes from v6:
> - Fixed the dt-bindings check in qcom,sc7280-wpss-pil.yaml
> - Fixed CDSP dt-bindings example node (compatible, glink-edge)
> - Fixed the clock-names used in wpss driver
> - Add support to get firmware-name from DTSI entry for wpss.
> 
> Changes from v4/v5:
> - Add yaml conversion for adsp/cdsp dt-bindings
> - Change clock names in wpss dt-bindings
> - Correct mistake in signed-off email ID
> 
> Rakesh Pillai (3):
>   dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML
>   dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
>   remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS
> 
>  .../bindings/remoteproc/qcom,hexagon-v56.txt       | 140 -------------
>  .../bindings/remoteproc/qcom,qcs404-cdsp-pil.yaml  | 161 +++++++++++++++
> .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml  | 219
> ++++++++++++++++++++  .../bindings/remoteproc/qcom,sdm845-adsp-pil.yaml
> | 160 +++++++++++++++
>  drivers/remoteproc/qcom_q6v5_adsp.c                | 227 +++++++++++++++++++--
>  5 files changed, 751 insertions(+), 156 deletions(-)  delete mode 100644
> Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.txt
>  create mode 100644
> Documentation/devicetree/bindings/remoteproc/qcom,qcs404-cdsp-pil.yaml
>  create mode 100644
> Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml
>  create mode 100644
> Documentation/devicetree/bindings/remoteproc/qcom,sdm845-adsp-pil.yaml
> 

Hi Bjorn,
Could you please help review this series and see if any further changes are required?

Thanks,
Manikanta