Re: [PATCH v9 23/43] KVM: x86: Move lookup of indexed CPUID leafs to helper

[Borislav Petkov]

On Fri, Jan 28, 2022 at 11:17:44AM -0600, Brijesh Singh wrote:
> From: Michael Roth <michael.roth@xxxxxxx>
> 
> Determining which CPUID leafs have significant ECX/index values is
> also needed by guest kernel code when doing SEV-SNP-validated CPUID
> lookups. Move this to common code to keep future updates in sync.
> 
> Reviewed-by: Venu Busireddy <venu.busireddy@xxxxxxxxxx>
> Signed-off-by: Michael Roth <michael.roth@xxxxxxx>
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> ---
>  arch/x86/include/asm/cpuid.h | 38 ++++++++++++++++++++++++++++++++++++
>  arch/x86/kvm/cpuid.c         | 19 ++----------------
>  2 files changed, 40 insertions(+), 17 deletions(-)
>  create mode 100644 arch/x86/include/asm/cpuid.h
> 
> diff --git a/arch/x86/include/asm/cpuid.h b/arch/x86/include/asm/cpuid.h
> new file mode 100644
> index 000000000000..00408aded67c
> --- /dev/null
> +++ b/arch/x86/include/asm/cpuid.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Kernel-based Virtual Machine driver for Linux cpuid support routines
> + *
> + * derived from arch/x86/kvm/x86.c
> + * derived from arch/x86/kvm/cpuid.c
> + *
> + * Copyright 2011 Red Hat, Inc. and/or its affiliates.
> + * Copyright IBM Corporation, 2008
> + */

I have no clue what you're trying to achieve by copying the copyright of
the file this comes from. As dhansen properly points out, those lines
in that function come from other folks/companies too so why even bother
with this?

git history holds the correct and full copyright anyway...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette