Re: [PATCH v2] x86/build: don't build CONFIG_X86_32 as -ffreestanding

[Nick Desaulniers]

On Thu, Feb 3, 2022 at 12:40 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> -ffreestanding typically inhibits "libcall optimizations" where calls to
> certain library functions can be replaced by the compiler in certain
> cases to calls to other library functions that may be more efficient.
> This can be problematic for embedded targets that don't provide full
> libc implementations.

While the bcmp shenanigans were ultimately resolved by
commit 5f074f3e192f ("lib/string.c: implement a basic bcmp")
(and this popped up again in
commit 1e1b6d63d634 ("lib/string.c: implement stpcpy")
).  I'm still very much in favor of this patch, and should have
pursued it. Thanks for resending!

-- 
Thanks,
~Nick Desaulniers