RE: [EXTERNAL] Re: [PATCH RESEND v4 1/4] dt-bindings: platform: microsoft: Document surface xbl

[Jarrett Schultz]

Rob Herring wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
> 
> On Tue, Dec 21, 2021 at 10:28:23AM -0800, Jarrett Schultz wrote:
> > From: Jarrett Schultz <jaschultz@xxxxxxxxxxxxx>
> >
> > +title: Surface Extensible Bootloader for Microsoft Surface Duo
> > +
> > +maintainers:
> > +  - Jarrett Schultz <jaschultz@xxxxxxxxxxxxx>
> > +
> > +description: |
> > +  Defined to expose information that is used during production when
> > +  device is in manufacturing mode. Some of the information included
> > +  in this imem section is -
> 
> If this is onchip sram, we have a binding for that. That's not an MFD.

I now have this driver working with nvmem, but I could not find the binding
that you are talking about here. Could you point me to the binding?

Thanks,
Jarrett

> 
> > +    * board_id
> > +    * battery_present
> > +    * hw_init_retries
> > +    * is_customer_mode
> > +    * is_act_mode
> > +    * pmic_reset_reason
> > +    * touch_fw_version
> > +    * ocp_error_location
> 
> nvmem binding doesn't work for describing these fields?
> 
> > +  See sysfs documentation for more information.
> 
> sysfs? Not relevant to the binding.
> 
> > +
> > +properties:
> > +  compatible:
> > +    const: simple-mfd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - ranges
> > +  - address-cells
> > +  - size-cells
> > +
> > +examples:
> > +  - |
> > +    / {
> > +        compatible = "foo";
> > +        model = "foo";
> 
> No need to make this the root node with a fake compatible.
> 
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        imem@146bf000 {
> > +          compatible = "simple-mfd";
> > +          reg = <0x0 0x146bf000 0x0 0x1000>;
> > +          ranges = <0x0 0x0 0x146bf000 0x1000>;
> > +          #address-cells = <1>;
> > +          #size-cells = <1>;
> > +          status = "okay";
> 
> Don't show status in examples.
> 
> > +
> > +          xbl@a94 {
> > +            compatible = "microsoft,sm8150-surface-duo-xbl";
> > +            reg = <0xa94 0x100>;
> > +            status = "okay";
> > +          };
> > +        };
> > +      };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 13f9a84a617e..5d0ca2a98b57 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12649,6 +12649,13 @@ F:	Documentation/driver-
> api/surface_aggregator/clients/dtx.rst
> >  F:	drivers/platform/surface/surface_dtx.c
> >  F:	include/uapi/linux/surface_aggregator/dtx.h
> >
> > +MICROSOFT SURFACE DUO XBL DRIVER
> > +M:	Jarrett Schultz <jaschultz@xxxxxxxxxxxxx>
> > +L:	linux-arm-msm@xxxxxxxxxxxxxxx
> > +L:	platform-driver-x86@xxxxxxxxxxxxxxx
> > +S:	Supported
> > +F:	Documentation/devicetree/bindings/platform/microsoft/surface-
> xbl.yaml
> > +
> >  MICROSOFT SURFACE GPE LID SUPPORT DRIVER
> >  M:	Maximilian Luz <luzmaximilian@xxxxxxxxx>
> >  L:	platform-driver-x86@xxxxxxxxxxxxxxx
> > --
> > 2.25.1
> >
> >