Re: [PATCH v9 28/43] x86/compressed/acpi: Move EFI kexec handling into common code

[Borislav Petkov]

On Fri, Jan 28, 2022 at 11:17:49AM -0600, Brijesh Singh wrote:
> +static struct efi_setup_data *get_kexec_setup_data(struct boot_params *boot_params,
> +						   enum efi_type et)
> +{
> +#ifdef CONFIG_X86_64
> +	struct efi_setup_data *esd = NULL;
> +	struct setup_data *data;
> +	u64 pa_data;
> +
> +	if (et != EFI_TYPE_64)
> +		return NULL;

Why that check here? That function is called for EFI_TYPE_64 only anyway.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette