Re: [PATCH] btrfs: send: in case of IO error log inode

[David Sterba]

On Wed, Feb 02, 2022 at 10:14:37PM +0200, Dāvis Mosāns wrote:
> Currently if we get IO error while doing send then we abort without
> logging information about which file caused issue.
> So log inode to help with debugging.

The Signed-off-by tag is missing.

> ---
>  fs/btrfs/send.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index d8ccb62aa7d2..945d9c01d902 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -5000,6 +5000,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
>  			if (!PageUptodate(page)) {
>  				unlock_page(page);
>  				put_page(page);
> +				btrfs_err(fs_info, "received IO error for inode=%llu", sctx->cur_ino);

A message here makes sense. I'd make it more explicit that it's for send
(the word "received" is kind of confusing), the inode number is not
unique identifier so the root id should be also printed, it's available
from the sctx->send_root and maybe also the file offset (taken from the
associated page by page_offset()).