Re: [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1
From: Doug Anderson
Date: Fri Feb 04 2022 - 17:15:19 EST
Hi,
On Thu, Feb 3, 2022 at 3:26 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Wed, Feb 2, 2022 at 1:24 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > +&pcie1_clkreq_n {
> > + bias-disable;
> > + drive-strength = <2>;
> > +};
>
> As per the discussion [1] then maybe the above should be
> `bias-pull-up` instead of `bias-disable`. I'm happy to spin this, have
> it fixed by the maintainer when applied, or do a follow-up patch to
> fix this. Please let me know.
Breadcrumbs: since most of this series landed but not this patch, I've
sent a new version with the fixup.
https://lore.kernel.org/r/20220204140550.v4.1.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid/