Re: [PATCH v3 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

[Lu Baolu]

On 2/5/22 1:10 PM, Fenghua Yu wrote:
> Hi, Baolu,
> On Sat, Feb 05, 2022 at 11:50:59AM +0800, Lu Baolu wrote:
> > Hi Fenghua,
> >
> > On 2022/1/29 4:28, Fenghua Yu wrote:
> > > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> > > index 92fea3fbbb11..ef03b2176bbd 100644
> > > --- a/drivers/iommu/intel/iommu.c
> > > +++ b/drivers/iommu/intel/iommu.c
> > > @@ -4781,7 +4781,7 @@ static int aux_domain_add_dev(struct dmar_domain *domain,
> > >    link_failed:
> > >    	spin_unlock_irqrestore(&device_domain_lock, flags);
> > >    	if (list_empty(&domain->subdevices) && domain->default_pasid > 0)
> > > -		ioasid_put(domain->default_pasid);
> > > +		ioasid_free(domain->default_pasid);
> > >    	return ret;
> > >    }
> > > @@ -4811,7 +4811,7 @@ static void aux_domain_remove_dev(struct dmar_domain *domain,
> > >    	spin_unlock_irqrestore(&device_domain_lock, flags);
> > >    	if (list_empty(&domain->subdevices) && domain->default_pasid > 0)
> > > -		ioasid_put(domain->default_pasid);
> > > +		ioasid_free(domain->default_pasid);
> > >    }
> > >    static int prepare_domain_attach_device(struct iommu_domain *domain,
> >
> > The domain->default_pasid is not relevant to SVA and it's being cleaned
> > up by another series. No need to take care of it in this series.
>
> Because ioasid_put() is renamed to ioasid_free() in this patch, without
> above changes, this series cannot be compiled.
>
> Thomas and I discussed how to handle aux_domain while you will remove
> the entire aux_domain code (https://lore.kernel.org/lkml/87zgnf29op.ffs@tglx/).
> The above changes are minimal and temporary changes to compile this series.
> The changes will be removed along with the entire aux_domain by your
> removing aux_domain series later in 5.18.

Okay. Make sense to me.

Best regards,
baolu