RE: [PATCH v3 7/8] memory: of: parse max-freq property

[Alim Akhtar]

Hi Krzysztof

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>Sent: Sunday, February 6, 2022 7:28 PM
>To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>; Rob Herring
><robh+dt@xxxxxxxxxx>; Lukasz Luba <lukasz.luba@xxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Dmitry Osipenko <digetx@xxxxxxxxx>; linux-
>kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
>pm@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx
>Subject: [PATCH v3 7/8] memory: of: parse max-freq property
>
>Passing the memory timings maximum frequency as an unit address was a
>workaround and instead 'max-freq' is preferred.  Look for 'max-freq'
>first and then fallback to 'reg'.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.ahtar@xxxxxxxxxxx>


> drivers/memory/of_memory.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
>index b94408954d85..bac5c7f34936 100644
>--- a/drivers/memory/of_memory.c
>+++ b/drivers/memory/of_memory.c
>@@ -212,8 +212,10 @@ static int of_lpddr3_do_get_timings(struct
>device_node *np,  {
> 	int ret;
>
>-	/* The 'reg' param required since DT has changed, used as 'max-freq'
>*/
>-	ret = of_property_read_u32(np, "reg", &tim->max_freq);
>+	ret = of_property_read_u32(np, "max-freq", &tim->max_freq);
>+	if (ret)
>+		/* Deprecated way of passing max-freq as 'reg' */
>+		ret = of_property_read_u32(np, "reg", &tim->max_freq);
> 	ret |= of_property_read_u32(np, "min-freq", &tim->min_freq);
> 	ret |= of_property_read_u32(np, "tRFC", &tim->tRFC);
> 	ret |= of_property_read_u32(np, "tRRD", &tim->tRRD);
>--
>2.32.0