Re: [PATCH v2 00/15] Make ETM register accesses consistent with sysreg.h

[James Clark]

On 07/02/2022 05:51, Anshuman Khandual wrote:
> Hi James,
> 
> On 2/3/22 5:35 PM, James Clark wrote:
>> James Clark (15):
>>   coresight: Make ETM4x TRCIDR0 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCIDR2 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCIDR3 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCIDR4 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCIDR5 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCCONFIGR register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCEVENTCTL1R register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCSTALLCTLR register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCVICTLR register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM3x ETMTECR1 register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCACATRn register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCSSCCRn and TRCSSCSRn register accesses
>>     consistent with sysreg.h
>>   coresight: Make ETM4x TRCSSPCICRn register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCBBCTLR register accesses consistent with
>>     sysreg.h
>>   coresight: Make ETM4x TRCRSCTLRn register accesses consistent with
>>     sysreg.h
> 
> The changes here are very similar to each other. But they are split
> into different patches according to register names just for better
> review process ? OR is there any other rationale ?

Yes just for the review process. I didn't see a way of reviewing them all
in one change because it's so big, and the only logical way to split it was
by register so I did it that way.

> 
> - Anshuman