Re: [PATCH v7 net-next 06/10] net: dsa: microchip: add support for phylink management

[Prasanna Vengateshan]

On Fri, 2022-02-04 at 18:14 +0000, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> able to be laid out with the two pause modes first followed by the
> speeds.
> 
> > +                     phy_interface_set_rgmii(config->supported_interfaces);
> > +
> > +                     __set_bit(PHY_INTERFACE_MODE_MII,
> > +                               config->supported_interfaces);
> > +                     __set_bit(PHY_INTERFACE_MODE_RMII,
> > +                               config->supported_interfaces);
> > +             }
> > +     }
> 
> You seem to be a non-legacy driver in this patch (good!) so please also
> add:
> 
>         config->legacy_pre_march2020 = false;
> 
> while DSA is transitioned over. Thanks.

Sure, thanks for the feedback. I will change it in the next revision.

Prasanna
>