Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages

From: Joe Perches
Date: Mon Feb 07 2022 - 12:34:36 EST


On Mon, 2022-02-07 at 19:21 +0200, Andy Shevchenko wrote:
> On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote:
> > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:
> > > In a couple of messages the constants, which have their definitions,
> > > are hard coded into the message text. Unhardcode them.
> >
> > Found by inspection or tool?
>
> Does it matter?

Yes. If it was done using a tool, then it could used treewide.

> No, a side effect of the following patch.

k