Re: [PATCH v1 01/10] iommu/vt-d: Move DMAR specific helpers into dmar.c

[Lu Baolu]

On 2/7/22 3:08 PM, Christoph Hellwig wrote:
> > --- a/include/linux/dmar.h
> > +++ b/include/linux/dmar.h
> > @@ -52,6 +52,32 @@ struct dmar_drhd_unit {
> >   	struct intel_iommu *iommu;
> >   };
> >   
> > +struct dmar_rmrr_unit {
>
> > +struct dmar_atsr_unit {
>
> > +struct dmar_satc_unit {
>
> What about moving all code that is using the structures to dmar.c
> to keep the definitions local?

It's difficult. References to these structures are scattered in iommu.c.

Best regards,
baolu