Re: [PATCH] openrisc: remove CONFIG_SET_FS

[Stafford Horne]

On Mon, Feb 07, 2022 at 05:14:43PM +0000, David Laight wrote:
> From: Christoph Hellwig
> > Sent: 07 February 2022 06:45
> > 
> > On Sun, Feb 06, 2022 at 10:36:47AM +0900, Stafford Horne wrote:
> > > Remove the address space override API set_fs() used for User Mode Linux.
> > 
> > This ain't UML :)
> > 
> > > +	return size <= TASK_SIZE && addr <= (TASK_SIZE - size);
> > 
> > No need for the inner braces.
> 
> Since TASK_SIZE is actually an address wouldn't be better to
> swap the condition around (in every architecture).
> 
> 	return addr <= TASK_SIZE && size <= TASK_SIZE - addr;

Hi David,

I like that, it is more clear, I will update to that in v3.

-Stafford