Re: [RFC PATCH v4 03/13] module: Move livepatch support to a separate file
From: Aaron Tomlin
Date: Tue Feb 08 2022 - 10:19:02 EST
On Tue 2022-02-08 12:42 +0100, Petr Mladek wrote:
> This should go to internal.h.
>
> Alternative is to move both is_livepatch_module() and
> set_livepatch_module() into include/linux/livepatch.h.
>
> I do not have strong opinion.
Hi Petr,
Firstly, thank you for your feedback.
In my opinion, I believe is_livepatch_module() should remain as it may
continue to be used externally i.e., outside of kernel/module/; albeit,
indeed set_livepatch_module() should be moved to kernel/module/internal.h
given its use is exclusive to core code.
Kind regards,
--
Aaron Tomlin