Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function

From: Marc Kleine-Budde
Date: Wed Feb 09 2022 - 03:45:25 EST


On 09.02.2022 08:40:48, Srinivas Neeli wrote:
> Hi Marc,
>
> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > Sent: Wednesday, February 9, 2022 2:02 PM
> > To: Srinivas Neeli <sneeli@xxxxxxxxxx>
> > Cc: wg@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; Michal
> > Simek <michals@xxxxxxxxxx>; linux-can@xxxxxxxxxxxxxxx;
> > netdev@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Appana Durga Kedareswara Rao
> > <appanad@xxxxxxxxxx>; Srinivas Goud <sgoud@xxxxxxxxxx>; git
> > <git@xxxxxxxxxx>
> > Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function
> >
> > On 09.02.2022 08:29:55, Srinivas Neeli wrote:
> > > > On 08.02.2022 21:50:53, Srinivas Neeli wrote:
> > > > > Add check for NAPI poll function to avoid enabling interrupts with
> > > > > out completing the NAPI call.
> > > >
> > > > Thanks for the patch. Does this fix a bug? If so, please add a Fixes:
> > > > tag that lists the patch that introduced that bug.
> > >
> > > It is not a bug. I am adding additional safety check( Validating the
> > > return value of "napi_complete_done" call).
> >
> > Thanks for your feedback. Should this go into can or can-next?
>
> If possible please apply on both branches.

That's not an option. Going for can-next as Michal Simek suggested.

Adding to linux-can-next/testing.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature