Re: [PATCH v2 5/9] random: do not xor RDRAND when writing into /dev/random

From: Jason A. Donenfeld
Date: Wed Feb 09 2022 - 06:49:53 EST


On Wed, Feb 9, 2022 at 9:31 AM Dominik Brodowski
<linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> Looks good generally, just one unrelated change slipped in:
>
> > bytes = min(count, sizeof(buf));
> > - if (copy_from_user(&buf, p, bytes))
> > + if (copy_from_user(buf, p, bytes))
> > return -EFAULT;

I'll often fix up very minor adjacent code style things. In this case,
`buf` is an array, so the code is equivalent, but I prefer the latter,
which is mostly what's used throughout the driver.

Jason