Re: [PATCHv2 00/29] TDX Guest: TDX core support
From: Borislav Petkov
Date: Wed Feb 09 2022 - 07:10:41 EST
On Wed, Feb 09, 2022 at 11:56:13PM +1300, Kai Huang wrote:
> TDX host support basically does detection of SEAM, TDX KeyIDs, P-SEAMLDR and
> initialize the TDX module, so likely TDX host support will introduce couple of
> new files to do above things respectively,
Why a couple of new files? How much code is that?
> and the majority of the code could be self-contained under some
> directory (currently under arch/x86/kernel/cpu/tdx/, but can be
> changed of course). Could we have some suggestions on how to organize?
So we slowly try to move stuff away from arch/x86/kernel/ as that is a
dumping ground for everything and everything there is "kernel" so that
part of the path is kinda redundant.
That's why, for example, we stuck the entry code under arch/x86/entry/.
I'm thinking long term we probably should stick all confidentail
computing stuff under its own folder:
arch/x86/coco/
for example. The "coco" being COnfidential COmputing, for lack of a
better idea.
And there you'll have
arch/x86/coco/tdx and
arch/x86/coco/sev
where to we'll start migrating the AMD stuff eventually too.
Methinks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette